ENH: Rename ResampleInPlaceImage to TransformGeometryImageFilter#2723
Merged
blowekamp merged 1 commit intoInsightSoftwareConsortium:masterfrom Sep 9, 2021
Merged
Conversation
github-actions
bot
added
area:Core
hjmjohnson
approved these changes
Sep 8, 2021
Member
hjmjohnson
left a comment
hjmjohnson
left a comment
There was a problem hiding this comment.
This is great! You also had identified bugs in pipeline processing. Will you be addressing those issues as well?
zivy
approved these changes
Sep 8, 2021
Member
Author
|
@hjmjohnson Yes, I am working on those now. I am prioritizing API changes to get them merged before the RC. Internal corrections and pipeline fixes are coming. |
Member
You are awesome! Thank you. |
blowekamp
force-pushed
the
TransformGeometryImageFilter
branch
from
7863712 to
f87bff1
Compare
dzenanz
approved these changes
Sep 8, 2021
Member
|
I guess merge as soon as the CI comes back green? |
Community discussion and voting converged TransformGeometryImageFilter is a more accurate name for the operation.
blowekamp
force-pushed
the
TransformGeometryImageFilter
branch
from
f87bff1 to
9827449
Compare
dzenanz
approved these changes
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community discussion and voting converged TransformGeometryImageFilter
is a more accurate name for the operation.
Renamed per the discussion: https://discourse.itk.org/t/simpleitk-euler3d-transform-adjust-image-origin-and-direction/3966/25