Replace zlib by zlib-ng

[dzenanz]

Some PRs in zlib-ng need to be merged, namely, zlib-ng/zlib-ng#1043 and zlib-ng/zlib-ng#1042. Preferably also zlib-ng/zlib-ng#1040 or zlib-ng/zlib-ng#1041. Until then, we will use develop branch in my fork.

[gdevenyi]

Thanks for picking this up @dzenanz. This is well beyond my ability to do right now, but I'll be watching closely for education.

[dzenanz]

This works for me. I updated the description with current state. It would be good if someone else tried this to confirm it works as expected.

[dzenanz]

I haven't tested installation yet.

[dzenanz]

I cleaned up the history. Testing the installation is still TODO.

[dzenanz]

Only a minor change was needed to fix installation (the latest commit). Now waiting for upstream to merge my patches.

[thewtex]

Since we are using CMake, the Makefile.in files should be removed from the import.

Why is CircleCI failing?

Can we add the name mangling patches to our branch?

[dzenanz]

Makefile.in files should be removed from the import

Will do.

Why is CircleCI failing?

/usr/bin/ld: cannot open linker script file /.../ITK/Modules/ThirdParty/ZLIB/src/itkzlib-ng/zlib.map: No such file or directory - I will add this file too. I don't know why only CircleCI needs it.

Can we add the name mangling patches to our branch?

This is currently in my fork. We could go with this while waiting for some variant of the patches to be merged. But that risks the patch to be reject on philosophical/maintenance burden grounds, thus forcing us to keep our own set of patches which will need to be occasionally rebased with probable conflicts..

[thewtex]

We could go with this while waiting for some variant of the patches to be merged. But that risks the patch to be reject on philosophical/maintenance burden grounds, thus forcing us to keep our own set of patches which will need to be occasionally rebased with probable conflicts.

Hopefully it will be merged upstream. Or, a different approach could be used upstream, and we will switch to that if it serves the need. But if we need to keep our own set of patches for the name mangling, then that is what we will have to do.

[thewtex]

🚀 well done @dzenanz @gdevenyi !

[gdevenyi]

well done @dzenanz @gdevenyi !

Thanks but @dzenanz definitely did all the hard work. I'm gonna carefully study these changes to learn a bit more CMAKE.

[thewtex]

@dzenanz we are getting the error:

CMake Error: File /Users/runner/work/1/s/Modules/ThirdParty/ZLIB/src/itkzlib-ng/zlib_name_mangling.h.empty does not exist.
CMake Error at Modules/ThirdParty/ZLIB/src/itkzlib-ng/CMakeLists.txt:1064 (configure_file):
  configure_file Problem configuring file

[dzenanz]

The last force-push takes care of that. ITK.macOS.Python "was cancelled". I will clean up this PR so it can be merged today.

[aaron-bray]

I still seem to be getting this itkzlib-ng not found on the latest master on windows

[aaron-bray]

Hang on, maybe my cmake did not refresh something after pull...

[aaron-bray]

Yeah, note to self, When MSVC asks you to reload, and you click ok, but then it says, sorry can't do that in the process of a build. Close MSVC and reopen it

Nothing to see here
Thanks for your time

[dzenanz]

Doesn't it give the option to stop the build in order to reload?