Skip to content

Update CircleCI ctest script#20

Closed
blowekamp wants to merge 2 commits intoInsightSoftwareConsortium:dashboardfrom
blowekamp:UpdateCircleCICTestScript
Closed

Update CircleCI ctest script#20
blowekamp wants to merge 2 commits intoInsightSoftwareConsortium:dashboardfrom
blowekamp:UpdateCircleCICTestScript

Conversation

@blowekamp
Copy link
Member

No description provided.

@blowekamp
Copy link
Member Author

@thewtex @fbudin69500

This patch is for the dashboard branch. Thanks!

@fbudin69500
Copy link
Contributor

LGTM

@blowekamp blowekamp changed the title Update circle cic test script Update circle ci ctest script Mar 14, 2017
@blowekamp blowekamp changed the title Update circle ci ctest script Update CircleCI ctest script Mar 14, 2017
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@blowekamp blowekamp force-pushed the UpdateCircleCICTestScript branch from 0f5e6dd to 7f00c60 Compare March 14, 2017 20:13
The organization of setting CTest variables is improve by grouping
them. Conditional are remove by making use of REQUIRE and DEFAULT
options for the set_from_env function.

The custom MAKEJ environment variable should be replaced by the
standard CTEST_BUILD_FLAGS being mapped from an environment variable
to a CTEST variable. MAKEJ remains to ensure the release branch still
compiles on CircleCI.

These changes follow improvements committed to SimpleITK.
@blowekamp blowekamp force-pushed the UpdateCircleCICTestScript branch from 7f00c60 to 014cdf3 Compare March 17, 2017 19:51
@blowekamp
Copy link
Member Author

This changes should be good to go into the dashboard branch.

@thewtex
Copy link
Member

thewtex commented Mar 17, 2017

Thanks. Merged to dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants