COMP: Fixes the HDF5 build on MinGW#1217
Closed
hjmjohnson wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Closed
COMP: Fixes the HDF5 build on MinGW#1217hjmjohnson wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
hjmjohnson wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
The HDF532defs.h were changed, as the number of arguments was wrong in Mingw32. This was referenced on InsightSoftwareConsortium#562 (comment) in InsightSoftwareConsortium#562 but wasn't incorporated. Left it as it didn't seem to be an issue anyone else had until yesterday. Co-authored by: John Muschelli <muschellij2@gmail.com>
hjmjohnson
force-pushed
the
fix-windows-build-hdf5
branch
from
7fcd08b to
71cf748
Compare
Closed
Member
|
This still needs some work for Visual Studio. |
Contributor
|
Just FYI, I believe this is still an issue without this fix: https://ci.appveyor.com/project/muschellij2/itkr/builds/27807695/job/wwjqfl5xqr8pvj6e |
Contributor
|
Did this get merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HDF532defs.h were changed, as the number of arguments was wrong in
Mingw32. This was referenced on #562 (comment) in #562 but wasn't
incorporated. Left it as it didn't seem to be an issue anyone else had
until yesterday.
Co-authored by: John Muschelli muschellij2@gmail.com
Superceeds #1216