COMP: fixed some -Wunused-template warnings by adding private namespaces

[hjmjohnson]

No description provided.

[hjmjohnson]

http://review.source.kitware.com/#/c/23318/

Sean McBride
Uploaded patch set 1.Apr 4, 2018

Sean McBride
Patch Set 1: OK Niels, this seemed to work too.Apr 4, 2018

Kitware Build Robot
Patch Set 1: Verified-1 Build Failed: CDash filtered results: https://open.cdash.org/index.php?&project=Insight&filtercount=3&field1=buildname/string&compare1=63&value1=23318-1&field2=buildstarttime/date&compare2=83&value2=2015-03-01&field3=buildstarttime/date&compare3=84&value3=2029-01-01Apr 5, 2018

Niels Dekker
Patch Set 1: Code-Review+1 Looks fine to me, thanks, Sean! For now, I think the name of the namespace 'itk_impl_details' is fine, but it can always be changed afterwards of course, as it is just an implementation detail :-) The Build Robot error "Process terminated due to timeout" seems unrelated to your patch: https://open.cdash.org/viewBuildError.php?buildid=5326344Apr 5, 2018

Hans J. Johnson

[N-Dekker]

I still think this is PR fine. In general it appears troublesome to use an unnamed namespace (anonymous namespace) in a header file. In general, unnamed namespaces only work well within CXX files. So instead, I think it makes sense to place implementation details in an "ITK-implementation-details-only" namespace.

[hjmjohnson]

Accidentally deleted the branch in my account.