BUG: Add parameter which stores the requested number of work units.#100
Conversation
|
Why did you close this? I thought Brad wanted to give it a minor update and it would be ready for merging. |
|
OOH!!!! I must have screwed up pushing items from gerrit to my account and accidentally deleted all my local branches! |
Somebody else came to the same conclusion. Is there any good/quick way to un-delete the branches? And I am not sure that will automatically reopen the issues. |
|
I did this manually. It should be good now. |
|
@blowekamp This should be ready soon. Just waiting on the macOS build. |
|
This patch should be ready, the build error: |
| << "returned more subdomains than were requested" ); | ||
| } | ||
|
|
||
| std::cout << "DomainThreader::DetermineNumberOfWorkUnits " << this->GetMultiThreader()->GetNumberOfWorkUnits() << std::endl; |
There was a problem hiding this comment.
Should this be removed before merging?
hjmjohnson
force-pushed
the
FixDomainThreaderNumberOfWorkUnits
branch
from
529c53f to
999eb5b
Compare
Adding an internal variable which store the number of work units requested. It is clamps to ITK_MAX_THREADS and initialized from the MultiThreader, which ensures a valid range. The variable is not reduce when the actual number of work units the domain can be partitioned into is computed. Previously, subsequent calls would only reduce the number of work units in the multi-threader and not restore the requested number.
hjmjohnson
force-pushed
the
FixDomainThreaderNumberOfWorkUnits
branch
from
999eb5b to
39233cf
Compare
|
Let's see if the dashboard returns cleanly. |
|
Thanks for the fix up. I'm just getting time to find out where all my code is now... |
3 participants
http://review.source.kitware.com/#/c/23864/
Bradley Lowekamp
Uploaded patch set 1.Nov 2 4:22 PM
Kitware Build Robot
Patch Set 1: Verified+1 Build Successful: CDash filtered results: https://open.cdash.org/index.php?&project=Insight&filtercount=3&field1=buildname/string&compare1=63&value1=23864-1&field2=buildstarttime/date&compare2=83&value2=2015-03-01&field3=buildstarttime/date&compare3=84&value3=2029-01-01Nov 2 5:30 PM
Hans J. Johnson
Patch Set 1: Code-Review+2Nov 3 2:02 PM
Bradley Lowekamp
9:30 AM
↩
Patch Set 1: Code-Review-1
(1 comment)
Modules/Core/Common/include/itkDomainThreader.hxx
Line 101:
This cout line needs to be deleted.
Dzenan Zukic
Patch Set 1: Code-Review+1 Looks good with the removal of the debugging output.9:39 AM