STYLE: Replace Iterator it = Iterator(x) with Iterator it(x)

Small style improvement to the previous commit.

- Following pull request #3959
commit ef24b65
"STYLE: Construct local variables by passing arguments directly (part 2)",
11 March, 2023

Modules/Filtering/ImageFilterBase/include/itkMovingHistogramImageFilterBase.hxx

@@ -52,10 +52,9 @@ MovingHistogramImageFilterBase<TInputImage, TOutputImage, TKernel>::SetKernel(co
   tmpSEImage->SetRegions(kernel.GetSize());
   tmpSEImage->Allocate();
   RegionType                                  tmpSEImageRegion = tmpSEImage->GetRequestedRegion();
-  ImageRegionIteratorWithIndex<BoolImageType> kernelImageIt =
-    ImageRegionIteratorWithIndex<BoolImageType>(tmpSEImage, tmpSEImageRegion);
-  KernelIteratorType kernel_it = kernel.Begin();
-  OffsetListType     kernelOffsets;
+  ImageRegionIteratorWithIndex<BoolImageType> kernelImageIt(tmpSEImage, tmpSEImageRegion);
+  KernelIteratorType                          kernel_it = kernel.Begin();
+  OffsetListType                              kernelOffsets;
 
   // create a center index to compute the offset
   IndexType centerIndex;

Modules/Numerics/Statistics/include/itkImageToNeighborhoodSampleAdaptor.hxx

@@ -126,7 +126,7 @@ ImageToNeighborhoodSampleAdaptor<TImage, TBoundaryCondition>::SetImage(const TIm
   {
     m_Region = m_Image->GetLargestPossibleRegion();
   }
-  NeighborhoodIteratorType neighborIt = NeighborhoodIteratorType(m_Radius, m_Image, m_Region);
+  NeighborhoodIteratorType neighborIt(m_Radius, m_Image, m_Region);
   neighborIt.GoToBegin();
   m_NeighborIndexInternal = neighborIt.GetBeginIndex();
   m_MeasurementVectorInternal.clear();
@@ -158,7 +158,7 @@ ImageToNeighborhoodSampleAdaptor<TImage, TBoundaryCondition>::SetRadius(const Ne
     m_Radius = radius;
     if (m_Image.IsNotNull())
     {
-      NeighborhoodIteratorType neighborIt = NeighborhoodIteratorType(m_Radius, m_Image, m_Region);
+      NeighborhoodIteratorType neighborIt(m_Radius, m_Image, m_Region);
       neighborIt.GoToBegin();
       m_NeighborIndexInternal = neighborIt.GetBeginIndex();
       m_MeasurementVectorInternal.clear();
@@ -186,7 +186,7 @@ ImageToNeighborhoodSampleAdaptor<TImage, TBoundaryCondition>::SetRegion(const Re
     m_UseImageRegion = false;
     if (m_Image.IsNotNull())
     {
-      NeighborhoodIteratorType neighborIt = NeighborhoodIteratorType(m_Radius, m_Image, m_Region);
+      NeighborhoodIteratorType neighborIt(m_Radius, m_Image, m_Region);
       neighborIt.GoToBegin();
       m_NeighborIndexInternal = neighborIt.GetBeginIndex();
       m_MeasurementVectorInternal.clear();

Modules/Segmentation/ConnectedComponents/include/itkConnectedComponentFunctorImageFilter.hxx

@@ -109,8 +109,7 @@ ConnectedComponentFunctorImageFilter<TInputImage, TOutputImage, TFunctor, TMaskI
   typename TMaskImage::ConstPointer mask = this->GetMaskImage();
   if (mask)
   {
-    ImageRegionConstIterator<MaskImageType> mit =
-      ImageRegionConstIterator<MaskImageType>(mask, output->GetRequestedRegion());
+    ImageRegionConstIterator<MaskImageType> mit(mask, output->GetRequestedRegion());
 
     mit.GoToBegin();
     oit.GoToBegin();