feat: remove unused variables states #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloe-renaud
approved these changes
Feb 7, 2025
QRuhier
force-pushed
the
feat/remove-unused-variables-types
branch
from
bc3cc51 to
fc71bdf
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove completely variables states that were not used since v3 (EDITED, FORCED, INPUTTED, PREVIOUS).
Those states are also removed from the schema of questionnaire ; but if we take a questionnaire having those states in the variables, they will still be in the data (with default values)
We decided to remove it also in the test files since it's not in the schema anymore, but previous tests were still working (except the tests using typed objects, then we had errors if we kept those keys that are not present in the source type)