remove geth dependency when extracting versioned hash list from a serialized blob tx#23
Merged
roberto-bayardo merged 1 commit intoeip-4844from Oct 5, 2022
Merged
Conversation
roberto-bayardo
force-pushed
the
roberto-bayardo/extract-hashes
branch
from
38cdc92 to
187d5ce
Compare
Inphi
reviewed
Oct 5, 2022
| // 258: start of the versioned hash offset within "message" (4 bytes) | ||
| // 262-: rest of the tx following message | ||
| // | ||
| // TODO: unit tests, remove dependency on github.com/protolambda/ztyp |
Owner
There was a problem hiding this comment.
btw, you can test using:
bazel test //beacon-chain/sync:go_default_test --test_filter='TestValidateBeaconBlockPubSub_ValidBlobKzgs'
or if you don't have bazel:
go test ./beacon-chain/sync/... -run 'TestValidateBeaconBlockPubSub.*'
Owner
There was a problem hiding this comment.
though a specific unit test for this function would also be desired.
Collaborator
Author
There was a problem hiding this comment.
thanks! The test seems to also rely on geth so it fails until I point it at my local geth repo, which I guess confirms it's WAI!
Inphi
approved these changes
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation reflects the blob tx layout from the recent eip-4844 fee market updates in ethereum/EIPs#5707