Misc cleanup #194
Merged
Misc cleanup #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name change itself is largely benign. The sole motivation is that `cargo test` defaults to alphabetical order for running tests and the `watcher::tests::the_guantlet` is the longest test by far while also being the last in the alphabet. This change makes the test suite go from taking 0.92 seconds to 0.64 seconds. `file_watcher::tests::the_gauntlet` also happened to take 0.64 seconds according to `cargo nextest run`
Not actually an important change, but some of the imports were sprawling, so I figured it was worth doing a little cleanup
CosmicHorrorDev
force-pushed
the
misc-cleanup
branch
from
e8c2b9d
to
0ea669c
Compare
CosmicHorrorDev
force-pushed
the
misc-cleanup
branch
from
0ea669c
to
6f2d2c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes quite a few various tweaks. The commit history is mostly clean up until the end because CI failures are a nightmare (that got mostly rebased away). The beefier parts have more detailed commit messages that cover various bits