Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Scheduled sending #1619

Open
wants to merge 58 commits into
base: master
Choose a base branch
from
Open

feat: Scheduled sending #1619

wants to merge 58 commits into from

Conversation

lebojo
Copy link
Contributor

@lebojo lebojo commented Nov 19, 2024

This PR introduces the Scheduled Send feature to the kMail iOS app, allowing users to schedule emails to be sent at a later time.

Key Changes

  • Added UI components for scheduling email (date and time picker).
  • Integrated scheduling logic with the existing email sending flow.
  • Updated backend API calls to handle scheduled send data.
  • Added validation for scheduling times (e.g., no past dates).
  • Enhanced error handling and user feedback for scheduling failures.
  • Reschedule header for scheduled email not sent yet
  • Localised strings
Capture d’écran 2024-11-19 à 16 40 33

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

Found 4 unused code occurences

Expand 
Mail/Views/New Message/Scheduled panel/ScheduleFloatingPanelView.swift:23:1: warning: Imported module 'MailResources' is unused
Mail/Views/New Message/Scheduled panel/ScheduleFloatingPanelView.swift:28:36: warning: Property 'draftManager' is unused
MailCore/Cache/MailboxManager/MailboxManageable.swift:67:24: warning: Parameter 'drafts' is unused
MailCore/Cache/MailboxManager/MailboxManager+Draft.swift:161:24: warning: Parameter 'drafts' is unused

@lebojo lebojo force-pushed the feat-Scheduled-sending branch 4 times, most recently from 72a3c83 to 07b27f2 Compare November 20, 2024 09:19
@lebojo
style: Init floating panel list and enum
209b328
@lebojo
style: All views done
02e35ff
@lebojo
fix: Testing integration with preprod
6252893
@lebojo
feat: Can now schedule message
ca681f3
@lebojo
fix: Enum date
4f05eb0
@lebojo
fix: Can recieve scheduled messages
bd3faff
@lebojo
feat: Show scheduled thread count
1520043
@lebojo
refactor: Add custom schedule to enum
74d9c3e
@lebojo
refactor: Same date view for thread + feat: Icon for scheduled messages
55e1d23
@lebojo
fix: Can delete scheduled draft
ec9b37a
@lebojo
feat: Change draft schedule from message View
fd8ae61
@lebojo
feat: Delete schedule
e055a99
@lebojo
fix: Better use for calendar
4e76037
@lebojo
feat: Collapse double func
1b91227
@lebojo
fix: Remove preprod
6ce9a0e
@lebojo
refactor: Send or schedule
df6bd7c
@lebojo
refactor: Delete doublons
97dd01c
@lebojo
feat: Custom schedule
c709404
@lebojo
fix: Edit draft
9f22fff
@lebojo
fix: See scheduled draft folder
65426b8
@lebojo
refactor: Delete multiple draft
ce1997c
@lebojo
fix: Localized strings
4f0143c
@lebojo
fix: Format
edbdd8a
@lebojo
refactor: Working system for new schedule
ca8df68
@lebojo
style: Localized string for cancelled schedule
1cbd9df
@lebojo
style: Refactor to match Figma's style
54d6db6
@lebojo
style: Match color of figma
af5f116
@lebojo
fix: Replace date iso8601 String to Date object
67b50e1
@lebojo
style: Match the figma's clock for HeaderDateView
f5db74d
@lebojo
feat: Schedule header match color of label
f885142
@lebojo
fix: Modifying schedule date
d8232db
@lebojo
fix: Color for schedule date matching figma's
fe28368
@lebojo
fix: Remove useless date
7996f13
@lebojo
style: Remove debug things
75abb24
@lebojo
feat: Add feature flag support for custom schedule
ec07fbb
@lebojo
feat: Add schedule discoveryView and set optional later button
df8d406
@lebojo
fix: Floating panel can't be hidden
5ea60a0
@lebojo
fix: Check if conversion worked
ea5d356
@lebojo
fix: Transition between panel and modal
2b4729c
@lebojo
style: Extract custom Schedule button into his own file
0f7948a
@lebojo
refactor: Clarify CustomScheduleModalView
10a330b
@lebojo
fix: Norm code
dafee76
@lebojo
style: Change color of schedule header to match figma
6404199
@lebojo
fix: Correct feature flag check
49cbf1f
@lebojo
refactor: New icons and icon names.
84dc165
@lebojo
fix: Update old tests
d24adbe
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 20, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lebojo lebojo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lebojo