Skip to content

chore: Bump tuist + Rewrite some dependencies declarations #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 7, 2025

Conversation

PhilippeWeidmann
Copy link
Member

No description provided.

Copy link

github-actions bot commented Sep 6, 2024

Found 0 unused code occurences

Expand
* No unused code detected.

@PhilippeWeidmann PhilippeWeidmann marked this pull request as draft September 9, 2024 07:09
@PhilippeWeidmann PhilippeWeidmann force-pushed the bump-tuist branch 2 times, most recently from 1c75821 to 1f41b23 Compare September 26, 2024 07:46
@PhilippeWeidmann PhilippeWeidmann force-pushed the bump-tuist branch 8 times, most recently from fb91893 to d4285c8 Compare October 8, 2024 14:46
@PhilippeWeidmann PhilippeWeidmann force-pushed the bump-tuist branch 6 times, most recently from e728e99 to 5289d54 Compare October 11, 2024 09:49
@PhilippeWeidmann PhilippeWeidmann force-pushed the bump-tuist branch 6 times, most recently from de19552 to f1707a7 Compare October 22, 2024 09:26
@PhilippeWeidmann PhilippeWeidmann force-pushed the bump-tuist branch 2 times, most recently from d91afcb to b114219 Compare January 27, 2025 08:36
@PhilippeWeidmann PhilippeWeidmann force-pushed the bump-tuist branch 3 times, most recently from 8b639a9 to 2fa87a2 Compare February 6, 2025 14:08
@PhilippeWeidmann PhilippeWeidmann marked this pull request as ready for review February 6, 2025 14:50
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I'll play with the app a bit if I find anything.

Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did test the app, the app extension, on iOS. InfomaniakDI is linked as a Framework. I still have a question for the mac target

Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac target works fine. Thanks 👍

@PhilippeWeidmann PhilippeWeidmann merged commit 03404da into master Feb 7, 2025
9 of 10 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the bump-tuist branch February 7, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants