Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR gate workflows #99

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Add PR gate workflows #99

merged 2 commits into from
Dec 7, 2022

Conversation

reginaldbondoc
Copy link
Contributor

@reginaldbondoc reginaldbondoc commented Dec 7, 2022 •
edited
Loading

Two separate workflows that run on creation of pull requests:

  • Frontend workflow watches for changes under frontend directory
  • Backend workflow watches for changes under backend directory

For now, only executes npm run build. But the step for running tests is already included but commented out.

Also squeezed in a fix on build-arg for frontend image build.

maidul98
maidul98 approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@maidul98 maidul98 merged commit 006f61a into Infisical:main Dec 7, 2022
@reginaldbondoc reginaldbondoc deleted the add-initial-quality-gate branch December 10, 2022 22:28
@maidul98 maidul98 mentioned this pull request Jan 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maidul98 maidul98 maidul98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reginaldbondoc @maidul98