Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notification Timeout #92

Merged
merged 8 commits into from
Dec 8, 2022
Merged

Add Notification Timeout #92

merged 8 commits into from
Dec 8, 2022

Conversation

asharonbaltazar
Copy link
Contributor

closes #89

List of Changes

  • Add info type for notifications. It's blue-colored.
  • Require notif.text for clearNotification. It didn't make sense to have clearNotification to clear all notifications.
  • Notification type within state is now Required<>. We need to ensure notifications within the NotificationProvider context have a type and timeoutMs
  • Add optional timeoutMs to create a new Notification
  • Add timeout capabilities for notifications to auto-hide after a specified amount of time (using the passed timeoutMs)
  • Move notifications to bottom right of screen and hide notification wrapper if !notifications.length

@asharonbaltazar
Copy link
Contributor Author

Screen.Recording.2022-12-07.at.12.23.16.PM.mov

@asharonbaltazar
Copy link
Contributor Author

I still have to add createNotification after specified actions, per #89.

Copy link
Collaborator

@vmatsiiako vmatsiiako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool! I love it!

@vmatsiiako
Copy link
Collaborator

Thank you so much :)

@vmatsiiako vmatsiiako merged commit 3c44975 into Infisical:main Dec 8, 2022
@asharonbaltazar asharonbaltazar deleted the feat-add-notif-timeout branch December 8, 2022 02:11
@asharonbaltazar asharonbaltazar restored the feat-add-notif-timeout branch December 8, 2022 17:03
@asharonbaltazar asharonbaltazar deleted the feat-add-notif-timeout branch December 8, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve (Error) Notifications
2 participants