-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I-36 Use pre-built frontend image instead of building Next.js app on boot #80
I-36 Use pre-built frontend image instead of building Next.js app on boot #80
Conversation
…ldbondoc/infisical into I-36-use-pre-built-frontend-image
Hey Egi, i am still reviewing the changes! Really good stuff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks go to me! Ping me if the git workflow is not working as expected so we can take a look together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Frontend changes
Dockerfile
for building imagesNODE_ENV
valueproduction
pre-bakedPOSTHOG_HOST
pre-baked with valuehttps://app.posthog.com
(can be overwritten during build viabuild-arg
)POSTHOG_API_KEY
will be pre-baked with "public" PostHog API key during build viabuild-arg
. Now, self-hosted clients will already have this set in the image they pull.standalone
filesNEXT_PUBLIC_POSTHOG_API_KEY
- when set, will replace the pre-baked one. One application of this is for the cloud-hosted clients, where we want to use the "private" PostHot API keyINFISICAL_TELEMETRY_ENABLED
(TELEMETRY_ENABLED
in.env
file setting the value ofINFISICAL_TELEMETRY_ENABLED
indocker-compose
) - when set tofalse
, will disable Infisical telemetry. Enabled by default.INFISICAL_TELEMETRY_ENABLED
orTELEMETRY_ENABLED
: Only the stringfalse
will disable telemetry. Any other value, including empty string, will enable telemetry.node
instead ofnext
(the latter has issue withSIGTERM
)Telemetry
Telemetry
classCompose files changes
docker-compose.yml
platform
qualifier as this PR includes support for building multi-platform images (see changes to GitHub Actions workflow below)build
definition for both backend and frontend services - we should be using the images instead of building (please correct me here if I'm wrong)docker-compose.dev.yml
image
property as we're building on boot anywaymongo
ofmongo-express
GitHub Actions workflow changes
docker-image
workflowamd64
&arm64
)amd64
are cached. Only thearm64
will be built anew)