Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard component #66

Merged
merged 3 commits into from
Dec 4, 2022
Merged

Update dashboard component #66

merged 3 commits into from
Dec 4, 2022

Conversation

SH5H
Copy link
Contributor

@SH5H SH5H commented Dec 4, 2022

issue: #47

I convert components in the dashboard to typescript.

and I check the drag & drop feature

2022-12-04.9.51.43.mov

@vmatsiiako
Copy link
Collaborator

@SH5H Quick question. Do UIEvent and WheelEvent need to be imported? It seems like they are not used anywhere if I understand correctly. Otherwise looks very good! Thank you so much :)

Screenshot 2022-12-03 at 23 29 01

@SH5H
Copy link
Contributor Author

SH5H commented Dec 4, 2022

Oh, that's my mistake.
Maybe we have to add a lint rule to avoid this happening.
May I add some lint rules in other PR?

@SH5H
Copy link
Contributor Author

SH5H commented Dec 4, 2022

I remove useless types.
And at last time, I forget to submit the Dropzone component So I add it this time

Copy link
Collaborator

@vmatsiiako vmatsiiako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense! Thank you so much for contributing :)

@vmatsiiako
Copy link
Collaborator

@SH5H Definitely! Feel free to add some lint rules, I think we can make our lint a bit stricter. Thank you!

@vmatsiiako vmatsiiako merged commit 86b12b1 into Infisical:main Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants