Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Adjustment][Sheen] removed prompt when deleting secret #500

Merged
merged 1 commit into from
Apr 17, 2023
Merged

[Adjustment][Sheen] removed prompt when deleting secret #500

merged 1 commit into from
Apr 17, 2023

Conversation

sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented Apr 15, 2023 •
edited
Loading

#367

Description 📣

  • This PR removes the "Delete Key" modal when deleting a secret in the dashboard. There is already a "Save changes" button for this one so it is no longer necessary. This will make deleting multiple secrets faster.

image
image

Type ✨

  • Bug fix
  • New feature
  • Breaking change
  • Documentation

Tests 🛠️

  1. Go to dashboard where all the secrets are listed
  2. Click the delete button
# Here's some code block to paste some code snippets

@sheensantoscapadngan sheensantoscapadngan changed the title [Adjustment][Sheen] removed additional prompt when deleting secret [Adjustment][Sheen] removed prompt when deleting secret Apr 15, 2023
@vmatsiiako
Copy link
Collaborator

This looks great! Thank you so much for the PR :)

@vmatsiiako vmatsiiako merged commit d1c62d6 into Infisical:main Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmatsiiako vmatsiiako vmatsiiako approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheensantoscapadngan @vmatsiiako