Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: added more scoping logic for namespace installation #3018

Merged
merged 1 commit into from
Jan 21, 2025
Merged

misc: added more scoping logic for namespace installation #3018

merged 1 commit into from
Jan 21, 2025

Conversation

sheensantoscapadngan
Copy link
Member

@sheensantoscapadngan sheensantoscapadngan commented Jan 21, 2025 •
edited
Loading

Description 📣

  • Added more scoping logic to ensure full compatibility with namespace-scoped installations
  • This PR disables the creation of cluster resources for metrics purposes when installed to a specific namespace

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@maidul98 maidul98 merged commit 938c06a into main Jan 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maidul98 maidul98 maidul98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheensantoscapadngan @maidul98