Refactored permission service for project to have project operation type validation #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidul98
reviewed
Jan 14, 2025
backend/src/ee/services/access-approval-policy/access-approval-policy-service.ts
Outdated
Show resolved
Hide resolved
akhilmhdh
force-pushed
the
refactor/permission-service-fn
branch
from
b81eea3 to
6f38d6c
Compare
maidul98
reviewed
Jan 14, 2025
backend/src/ee/services/access-approval-request/access-approval-request-service.ts
Outdated
Show resolved
Hide resolved
maidul98
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Previously, we used to check a project operation is correctly for the respective project type using an additional
ForbidOnInvalidProjectfunction from permission service. The issue with this approach is folks may forget to add it. Thus refactoring the permission functiion to accept an object with all keys and operation type key.Globalkey means an operation that can be made against any type.Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets