feat(audit-logs): shared secrets audit logs #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR introduces support for secret sharing audit logs. The 3 new events are:
The created/deleted events will only happen if the secret is created within an organization. And the read event will be logged regardless if it's a public user, or an authenticated organization member reading the secret. This means we now have a new actor type called
Unknown User. The Unknown user actor type will be used when the actor isn't authenticated.Smaller:
I also added
isClearableto the project selector in the audit logs tab, and removed the useEffect that made it default to a project on load.Type ✨