-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto capitalization toggle #292
Auto capitalization toggle #292
Conversation
@HasanMansoor4 I think this is awesome!! It makes a lot of sense! Just two minor things:
|
Yeah I just noticed the merge conflicts just now lol. I'm not that experienced with React/Next.js tbh I'll look into it and keep you updated.
The auto capitalization boolean isn't backfilled for previous documents, but im using the ?? operator to default to true for undefined values. is this okay? I'd love some feedback from @dangtony98 |
Hi @mv-turtle and @dangtony98, so I got the component refactored and its now using react query, I also removed the save button as I don't think there's a need for it. Would love some reviews. Thank you! |
Hey @HasanMansoor4! Sorry for taking some time to review this ... I've left 2 comments on the backend side of things; just some small endpoint-naming change and fixing spelling for the controller function. Other than that, it looks great to me! |
Thank you @dangtony98. Yeah all your comments make sense, I have them fixed now. |
@mv-turtle Are you good with this PR with regards to frontend? I'm good on my end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great! Thank you so much for contributing @HasanMansoor4 :)
Description 📣
New feature related to issue #276 Allow the user to toggle off/on the Auto Capitalization of secrets keys, by having a checkbox in the settings. I would love some feedback as this is my very first open source contribution. Thank you!
Screenhot