fix site url on pdf to be .env/SITE_URL & typo in website titles & Wrong Copyright message #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix typo in titles.
|
KunalSin9h
changed the title
|
Fix Blank Copyright message
|
KunalSin9h
changed the title
maidul98
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #263 - Improves Login URL for Self-Hosted Infisical Instances
Problem:
The emergency kit PDF contains a hard-coded login URL (https://app.infisical.com/login) that is not suitable for users who self-host Infisical.
Solution:
This pull request replaces the hard-coded URL with the use of the SITE_URL environment variable, allowing for a dynamic and customized login URL for self-hosted instances.
Benefit:
This change improves the functionality and flexibility of the emergency kit PDF for self-hosted Infisical users, making it more user-friendly and adaptable to their specific setup.