Fix(Azure Key Vault): Ignore disabled secrets #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maidul98
reviewed
Nov 26, 2024
backend/src/services/integration-auth/integration-sync-secret.ts
Outdated
Show resolved
Hide resolved
maidul98
approved these changes
Nov 26, 2024
OmarMcAdam
deleted the
omar/eng-1952-address-key-vault-integration-failing-due-to-disabled-secret
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This fix ensures we only attempt to sync Azure Key Vault secrets that are not disabled in Azure.
Now:
Previously fetching the disabled key would throw an error, and block remaining sync functions
Type ✨
Tests 🛠️
Manually tested by creating disabled secrets in Azure and manually triggering sync to replicate issue and create fix