Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Improvements #279

Merged
merged 5 commits into from
Feb 1, 2023
Merged

CI Improvements #279

merged 5 commits into from
Feb 1, 2023

Conversation

jon4hz
Copy link
Contributor

@jon4hz jon4hz commented Feb 1, 2023

No description provided.

@jon4hz
Copy link
Contributor Author

jon4hz commented Feb 1, 2023

ffda30b might be a bit opinionated but adding a -devel prefix allows you to distinguish actual releases from snapshots built with goreleaser build --clean --snapshot.

Copy link
Collaborator

@maidul98 maidul98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff! 🚀

@maidul98 maidul98 merged commit 87fd5e3 into Infisical:main Feb 1, 2023
maidul98 added a commit that referenced this pull request Feb 1, 2023
This reverts commit 87fd5e3, reversing
changes made to 2c4e066.
@maidul98
Copy link
Collaborator

maidul98 commented Feb 1, 2023

It looks like when i install via brew with your change, we get

Error: An exception occurred within a child process:
  NameError: undefined local variable or method `infisical' for #<Formulary::FormulaNamespaceba3a130640a0e57a00d3373d0bbc296b::Infisical:0x00007fca3cc55b08>

I will roll back so our users do not downloaded this version

@jon4hz
Copy link
Contributor Author

jon4hz commented Feb 1, 2023

yikes, sorry for the trouble. I'll take a look this evening an make a PR

jon4hz added a commit to jon4hz/infisical that referenced this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants