Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(integrations): Add AWS Secrets Manager IAM Role + Region #2778

Merged
merged 4 commits into from
Nov 22, 2024
Merged

feat(integrations): Add AWS Secrets Manager IAM Role + Region #2778

merged 4 commits into from
Nov 22, 2024

Conversation

McPizza0
Copy link
Contributor

@McPizza0 McPizza0 commented Nov 22, 2024 •
edited
Loading

Description 📣

This PR Adds additional metadata (AWS Region & IAM Role) to AWS Secrets Manager settings page
CleanShot 2024-11-22 at 21 11 53@2x

Closes ENG-1753 and ENG-1850

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

Manually tested by setting up AWS integration and verifying data is displayed correctly.

@McPizza0 McPizza0 marked this pull request as ready for review November 22, 2024 20:24
DanielHougaard
DanielHougaard requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@DanielHougaard DanielHougaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

backend/src/server/routes/v1/integration-router.ts Outdated Show resolved Hide resolved
backend/src/server/routes/v1/integration-router.ts Outdated Show resolved Hide resolved
backend/src/server/routes/v1/integration-router.ts Outdated Show resolved Hide resolved
backend/src/services/integration/integration-service.ts Outdated Show resolved Hide resolved
backend/src/services/integration/integration-service.ts Outdated Show resolved Hide resolved
frontend/src/hooks/api/integrations/types.ts Show resolved Hide resolved
.../src/views/IntegrationsPage/IntegrationDetailsPage/components/IntegrationSettingsSection.tsx Show resolved Hide resolved
@McPizza0 McPizza0 merged commit a692148 into main Nov 22, 2024
6 checks passed
@McPizza0 McPizza0 deleted the omar/eng-1753-add-iam-role-details-to-integration-overview branch December 5, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielHougaard DanielHougaard DanielHougaard approved these changes

Assignees

@McPizza0 McPizza0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@McPizza0 @DanielHougaard