Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli-installer): readme improvements #2762

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

DanielHougaard
Copy link
Contributor

Description 📣

This PR contains some simple README improvements for our new NPM CLI Installer, to reduce confusion between the CLI and Node SDK

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

@DanielHougaard DanielHougaard self-assigned this Nov 19, 2024
@DanielHougaard DanielHougaard requested review from maidul98 and scott-ray-wilson and removed request for maidul98 November 19, 2024 23:25
Copy link
Contributor

@scott-ray-wilson scott-ray-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor typos but also some suggestions!

npm/README.md Outdated Show resolved Hide resolved
npm/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@scott-ray-wilson scott-ray-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanielHougaard DanielHougaard merged commit 75df898 into main Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants