misc: address role slug issue in invite user endpoint #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielHougaard
requested changes
Nov 18, 2024
|
Actually this in theory a breaking change. If someone is passing in an empty array for the roles, their workflow will break. As I see it, this is not how the endpoint is intended to be used in the first place though. Either the user should pass in an array with items, or pass nothing at all. Question is, are we okay with adding this potentially breaking change? I am personally okay with it, as the risk appears low |
DanielHougaard
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
This PR ensures that if roleSlugs is defined during user project invite, the roles are actually assigned correctly
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets