-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: TOTP authenticator #2731
feat: TOTP authenticator #2731
Conversation
For the "TOTP MFA screen after login," would it be possible to keep this as the cleaner 6-digit input similar to the email confirmation code input component? This might be cleaner but is dependent on if the code is always the same digit length or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! You really thought out all the edge cases, great work - a few code comments and then left some UI/flow feedback/thoughts in this notion doc: https://www.notion.so/infisical/MFA-Feedback-3a95fe28840847f594c76d7da7eb42c3?pvs=4
frontend/src/views/Settings/OrgSettingsPage/components/OrgAuthTab/OrgGenericAuthSection.tsx
Outdated
Show resolved
Hide resolved
frontend/src/views/Settings/PersonalSettingsPage/SecuritySection/MFASection.tsx
Outdated
Show resolved
Hide resolved
frontend/src/views/Settings/PersonalSettingsPage/SecuritySection/MFASection.tsx
Outdated
Show resolved
Hide resolved
The recovery codes are longer than the verify codes :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also probably include docs update for mfa: https://infisical.com/docs/documentation/platform/mfa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - few nits
Description 📣
This PR adds support for new MFA method: time-based one-time password
This has been tested with Duo and Google authenticator, but current integration should be compatible with other authenticator apps as well
New screens:
TOTP MFA screen after login:
Personal settings screen with registered TOTP
Personal settings screen without registered TOTP
Organization MFA settings:
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets