Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): migrated to ts completed. #224

Merged
merged 1 commit into from
Jan 15, 2023
Merged

feat(frontend): migrated to ts completed. #224

merged 1 commit into from
Jan 15, 2023

Conversation

akhilmhdh
Copy link
Member

Completed migration to ts for all left out files including

  1. _app.js
  2. dialogs

Screenshot 2023-01-15 at 9 35 10 PM

vmatsiiako
vmatsiiako approved these changes Jan 15, 2023
View reviewed changes
Copy link
Collaborator

@vmatsiiako vmatsiiako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!
I found a bug with with creating a new project, but it's not related to your changes. WIll fix this ASAP

@vmatsiiako vmatsiiako merged commit c563548 into Infisical:main Jan 15, 2023
@snyk-bot snyk-bot mentioned this pull request Feb 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmatsiiako vmatsiiako vmatsiiako approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akhilmhdh @vmatsiiako