Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration(frontend): migrated frontend files to ts execpt dialog component #222

Merged
merged 1 commit into from
Jan 15, 2023
Merged

migration(frontend): migrated frontend files to ts execpt dialog component #222

merged 1 commit into from
Jan 15, 2023

Conversation

akhilmhdh
Copy link
Member

  1. Completed migration to ts except dialog components and removed ts errors of all files till now.
  2. Some i have put any type which are basically API calls over state which will soon be replaced with react-query.

Screenshot 2023-01-15 at 12 12 53 AM

@akhilmhdh
Copy link
Member Author

akhilmhdh commented Jan 14, 2023 •
edited
Loading

SIdenote: Don't mind the non uniform linting codebase having. Let's do that after ts migration complete. Ill put it with prettier

vmatsiiako
vmatsiiako approved these changes Jan 15, 2023
View reviewed changes
Copy link
Collaborator

@vmatsiiako vmatsiiako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked everything. Looks great!

@vmatsiiako vmatsiiako merged commit 564367d into Infisical:main Jan 15, 2023
@snyk-bot snyk-bot mentioned this pull request Feb 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmatsiiako vmatsiiako vmatsiiako approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akhilmhdh @vmatsiiako