-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding support for fr language 🌎🇫🇷 #210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmatsiiako
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much once again @Grraahaam! This is amazing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📣
Adding support for
fr
language.This pull request refers to this issue : #181 (
Help us translate Infisical
)I had to change some frontend code as well to make the changes work as expected, I'm not an expert so please take a look ✌️
👀 - looking for help, ✔️ - ready,⚠️ - in progress
inspired by #199
Concerns
I'm wondering about the below meanings :
How could users be "formed into projects"? IMO the wording isn't pretty clear in that case
Moreover, by testing the changes I've made with the latest version I had, some translation don't seem to be applied... AFAIK it seems to be related to the next-i18n namespace concept : https://www.i18next.com/principles/namespaces (Edit: seems to be fixed now with the latest Infisical commits)
But there's still some hard-coded text at some places, I guess it'll be fixed with time ✌️
Tests 🛠️
Follow the development setup to test it locally : https://infisical.com/docs/contributing/developing