Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add popup before secret delete #197

Merged
merged 3 commits into from
Jan 7, 2023
Merged

Add popup before secret delete #197

merged 3 commits into from
Jan 7, 2023

Conversation

JoaoVictor6
Copy link
Contributor

@JoaoVictor6 JoaoVictor6 commented Jan 6, 2023 •
edited
Loading

Add popup before secret delete

This is my solution for issue #175 :)

Goals

  • Create a dialog
  • Isolate logic for delete action in a component
  • Improve types on delete scope

Demo

2023-01-05_23-29-18.mp4

The bug on the version history box on sidebar has because when recording the server wasn't running :p

@JoaoVictor6 JoaoVictor6 changed the title confirm secret key delete Add popup before secret delete Jan 6, 2023
@JoaoVictor6 JoaoVictor6 marked this pull request as ready for review January 6, 2023 02:42
vmatsiiako
vmatsiiako approved these changes Jan 7, 2023
View reviewed changes
Copy link
Collaborator

@vmatsiiako vmatsiiako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great! Thank you so much for the contribution :)

@vmatsiiako vmatsiiako merged commit 89136aa into Infisical:main Jan 7, 2023
@JoaoVictor6 JoaoVictor6 deleted the confirm-secret-key-delete branch January 7, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmatsiiako vmatsiiako vmatsiiako approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoaoVictor6 @vmatsiiako