Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added setup for production observability (metrics via OTEL) #1924

Merged
merged 12 commits into from
Nov 19, 2024

misc: updated service name

41e36df
Select commit
Loading
Failed to load commit list.
Merged

feat: added setup for production observability (metrics via OTEL) #1924

misc: updated service name
41e36df
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks skipped Nov 19, 2024 in 22s

You tagged this GitGuardian alert as a false positive

8 secrets were uncovered from the scan of 12 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #1924: misc/metrics-observability 👉 main
GitGuardian id GitGuardian status Secret Commit Filename
9387833 Triggered Generic Password 0693f81 prometheus.yml View secret
9387833 Triggered Generic Password 33b49f4 docker-compose.dev.observable.yml View secret
9387833 Triggered Generic Password 33b49f4 docker-compose.dev.observable.yml View secret
9387833 Triggered Generic Password fc3a409 prometheus.yml View secret
9605380 Triggered Generic Private Key a6137f2 backend/e2e-test/routes/v3/secrets-v2.spec.ts View secret
9605380 Triggered Generic Private Key a6137f2 backend/e2e-test/routes/v3/secrets-v2.spec.ts View secret
9387833 Triggered Generic Password d71c85e docker-compose.dev.observable.yml View secret
9387833 Triggered Generic Password d71c85e docker-compose.dev.observable.yml View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.