Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to import/export secrets with comments #188

Merged
merged 9 commits into from
Jan 7, 2023

Conversation

mocherfaoui
Copy link
Contributor

closes #74

few things to note:

  • it would be better if some functions are moved to separate files like getSecrets and checkOverrides
  • I used Menu as a dropdown menu from headless/ui, I think it would be better if it's extracted to a reusable component for future use
    • there is an issue with the dropdown menu, the menu doesn't close after a button is clicked. i'm investigating this issue at the moment
  • it would be better the onButtonPressed prop from Button component is optional so it can be used as a trigger like the case above

@vmatsiiako
Copy link
Collaborator

Hi @mocherfaoui! Sorry for taking so long to review. This looks awesome!

Merging this right now. Meanwhile, a few things to mention:

  • as you mentioned, it would be nice to put those secret function into corresponding files. Feel free to do this, or I will try to do it in one of the future commits.
  • What do you think we should do about nested .yml files? Cyrrently it just converts a nested value to:

Screenshot 2023-01-06 at 15 59 20

@vmatsiiako
Copy link
Collaborator

@mocherfaoui I can't pass this Frontend Check... :(((

Would you be able to have a look? Then it should be ready to merge

Copy link
Collaborator

@vmatsiiako vmatsiiako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it! Merging right now 🚀
Though please let me know what you think of the questions above :)

@vmatsiiako vmatsiiako merged commit eed6c75 into Infisical:main Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add import/export of .yml files
2 participants