feat(#31): implemented api for environment crud operations #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome! Makes total sense to me! I feel like @dangtony98 might say that the routes should be like 'workspace/:workspaceId/environment'. I know that he is doing some v2 revamp which should create a common way of naming routes. @dangtony98 do you have any opinions here? |
Zamion101
suggested changes
Jan 8, 2023
There was a problem hiding this comment.
There needs some changes and further discussion on how to handle envrionments in upcoming V2 API by @dangtony98
@Zamion101 And yes. I have talked with tony and now this PR is in a waiting for v2 routes to come inti picture and launched |
…ith backend fix(Infisical#31): fixed all v2 release conflict
akhilmhdh
changed the title
|
Looking into this right now! Thank you for such detailed description! |
vmatsiiako
reviewed
Jan 14, 2023
vmatsiiako
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do
This will enable workspace environment crud operations
Screenshots
Expand
List Env
Create Env
Update Env
Delete Env
Dashboard
Service Token
Integration Page