Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secret versioning #171

Merged
merged 14 commits into from
Dec 26, 2022
Merged

Secret versioning #171

merged 14 commits into from
Dec 26, 2022

Conversation

dangtony98
Copy link
Collaborator

Added secret versioning + secret snapshot functionality for backend (under EE):

  • Secret versioning: Now stores encrypted versions of each secret so they can be rolled back individually.
  • Secret snapshot: Now takes and stores a snapshot of all workspace secrets after any push.
  • GET route to get secret snapshots.
  • GET route to get secret versions.

@gitguardian
Copy link

gitguardian bot commented Dec 26, 2022

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
5324534 Generic High Entropy Secret 9bbf380 .env.example View secret
5324535 Generic High Entropy Secret 9bbf380 .env.example View secret
5324536 Generic High Entropy Secret 9bbf380 .env.example View secret
5324537 Generic High Entropy Secret 9bbf380 .env.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@dangtony98 dangtony98 merged commit a07bfbe into main Dec 26, 2022
@dangtony98 dangtony98 deleted the secret-versioning branch December 26, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant