Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard sidebar #169

Merged
merged 12 commits into from
Dec 26, 2022
Merged

Dashboard sidebar #169

merged 12 commits into from
Dec 26, 2022

Conversation

vmatsiiako
Copy link
Collaborator

Still need to fix some bugs though this should be ready to merge after the CLI is updated to prioritize overridden secrets

What this adds?

  • A sidebar instead of a popup for each secret.

Screenshot 2022-12-25 at 10 18 22

- Conversion of some files to TS - Performance optimizations for the dashboard

@gitguardian
Copy link

gitguardian bot commented Dec 26, 2022

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
5324534 Generic High Entropy Secret 740100a .env.example View secret
5324535 Generic High Entropy Secret 740100a .env.example View secret
5324536 Generic High Entropy Secret 740100a .env.example View secret
5324537 Generic High Entropy Secret 740100a .env.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@vmatsiiako vmatsiiako merged commit 0e78336 into main Dec 26, 2022
@vmatsiiako vmatsiiako deleted the dashboard-sidebar branch December 28, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant