Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend/signup+login): improve accessibility and UX #165

Merged

Conversation

naorpeled
Copy link
Contributor

@naorpeled naorpeled commented Dec 24, 2022

  • wrapped forms with the form HTML attribute for users to be able to submit using their keyboards
  • added type prop to the button shared component (was needed for some form buttons not to act as submit ones)
  • adjusted error showing behavior in login page: errors won't be shown when the form is in a loading state or after changing anything in the input fields' values

vmatsiiako
vmatsiiako previously approved these changes Dec 25, 2022
Copy link
Collaborator

@vmatsiiako vmatsiiako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! @naorpeled thank you so much for the contribution! :)

vmatsiiako
vmatsiiako previously approved these changes Dec 25, 2022
@gitguardian
Copy link

gitguardian bot commented Dec 25, 2022

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 142ed15 .env.example View secret
- Generic High Entropy Secret 142ed15 .env.example View secret
- Generic High Entropy Secret 142ed15 .env.example View secret
- Generic High Entropy Secret 142ed15 .env.example View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@vmatsiiako
Copy link
Collaborator

There are some merge conflicts, will check in a bit 🤔

@vmatsiiako
Copy link
Collaborator

Solved the merge conflicts! Merging! :)

@vmatsiiako vmatsiiako merged commit f642a46 into Infisical:main Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants