Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix login runtime error #128

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Fix login runtime error #128

merged 1 commit into from
Dec 21, 2022

Conversation

SH5H
Copy link
Contributor

@SH5H SH5H commented Dec 18, 2022

BEFORE
스크린샷 2022-12-18 오후 3 46 51

AFTER
image

I found I miss the error handling with login. So I fix it.

@vmatsiiako
Copy link
Collaborator

Thank you for reminding @CristianBelli01k! I looked at this and forgot to approve/merge!
And Thank you for the contribution @SH5H! This makes a lot of sense! :)

@vmatsiiako vmatsiiako merged commit 2bd9f4e into Infisical:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmatsiiako vmatsiiako vmatsiiako approved these changes

@CristianBelli01k CristianBelli01k CristianBelli01k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SH5H @vmatsiiako @CristianBelli01k