Skip to content

Commit

Permalink
Minor typos fixed and style changes
Browse files Browse the repository at this point in the history
  • Loading branch information
vmatsiiako committed Feb 4, 2023
1 parent fb62fa4 commit fca003d
Show file tree
Hide file tree
Showing 11 changed files with 38 additions and 36 deletions.
2 changes: 1 addition & 1 deletion frontend/src/components/basic/table/EnvironmentsTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ const EnvironmentTable = ({ data = [], onCreateEnv, onDeleteEnv, onUpdateEnv }:
) : (
<tr>
<td colSpan={4} className="pt-7 pb-4 text-center text-bunker-400">
No environmants found
No environments found
</td>
</tr>
)}
Expand Down
7 changes: 4 additions & 3 deletions frontend/src/components/v2/Button/Button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ const buttonVariants = cva(
colorSchema: {
primary: ['bg-primary', 'text-black', 'border-primary hover:bg-opacity-80'],
secondary: ['bg-mineshaft', 'text-gray-300', 'border-mineshaft hover:bg-opacity-80'],
danger: ['bg-red', 'text-white', 'border-red']
danger: ['bg-red', 'text-white', 'border-red hover:bg-opacity-90']
},
variant: {
solid: '',
outline: ['bg-transparent', 'border-2', 'border-solid'],
plain: ''
},
isDisabled: {
true: 'bg-opacity-40 cursor-not-allowed',
true: 'bg-mineshaft opacity-40 cursor-not-allowed',
false: ''
},
isFullWidth: {
Expand Down Expand Up @@ -147,7 +147,8 @@ export const Button = forwardRef<HTMLButtonElement, ButtonProps>(
className={twMerge(
'shrink-0 cursor-pointer transition-all',
loadingToggleClass,
size === 'xs' ? 'mr-1' : 'mr-2'
leftIcon && 'ml-2',
size === 'xs' ? 'mr-1' : 'mr-3'
)}
>
{leftIcon}
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/v2/Card/Card.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export type CardTitleProps = {
};

export const CardTitle = ({ children, className, subTitle }: CardTitleProps) => (
<div className={twMerge('p-6 pb-4 font-sans text-xl font-medium', className)}>
<div className={twMerge('px-6 py-4 font-sans text-xl font-medium', className)}>
{children}
{subTitle && <p className="py-1 text-sm font-normal text-gray-400">{subTitle}</p>}
</div>
Expand All @@ -29,7 +29,7 @@ export type CardBodyProps = {
};

export const CardBody = ({ children, className }: CardBodyProps) => (
<div className={twMerge('p-6 pb-4 pt-0', className)}>{children}</div>
<div className={twMerge('px-6 pb-6 pt-0', className)}>{children}</div>
);

export type CardProps = {
Expand Down
16 changes: 8 additions & 8 deletions frontend/src/components/v2/IconButton/IconButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ const iconButtonVariants = cva(
{
variants: {
colorSchema: {
primary: ['bg-primary', 'text-black', 'border-primary hover:bg-opacity-80'],
secondary: ['bg-mineshaft', 'text-gray-300', 'border-mineshaft hover:bg-opacity-80'],
danger: ['bg-red', 'text-white', 'border-red']
primary: ['bg-primary', 'text-black', 'border-primary hover:opacity-80'],
secondary: ['bg-mineshaft', 'text-gray-300', 'border-mineshaft hover:bg-bunker-400'],
danger: ['bg-[#973939] hover:bg-red', 'text-white', 'border-red']
},
variant: {
solid: '',
Expand All @@ -40,10 +40,10 @@ const iconButtonVariants = cva(
false: ''
},
size: {
xs: ['text-xs', 'py-1', 'px-2'],
sm: ['text-sm', 'py-2', 'px-3'],
md: ['text-md', 'py-3', 'px-4'],
lg: ['text-lg', 'py-3', 'px-6']
xs: ['text-xs', 'py-2', 'px-2'],
sm: ['text-sm', 'py-3', 'px-3'],
md: ['text-md', 'py-4', 'px-4'],
lg: ['text-lg', 'py-6', 'px-6']
}
},
compoundVariants: [
Expand Down Expand Up @@ -97,7 +97,7 @@ export const IconButton = forwardRef<HTMLButtonElement, IconButtonProps>(
ariaLabel,
isDisabled = false,
className,
size = 'md',
size = 'sm',
variant = 'solid',
isRounded = true,
colorSchema = 'primary',
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/v2/Input/Input.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ type Props = {
};

const inputVariants = cva(
'input w-full py-2 text-gray-400 placeholder-gray-500 placeholder-opacity-50',
'input w-full py-2 text-gray-400 placeholder-gray-500 placeholder-opacity-50 outline-none focus:ring-2',
{
variants: {
size: {
Expand Down Expand Up @@ -91,8 +91,8 @@ export const Input = forwardRef<HTMLInputElement, InputProps>(
ref={ref}
disabled={isDisabled}
className={twMerge(
leftIcon ? 'pl-9' : 'pl-4',
rightIcon ? 'pr-9' : 'pr-4',
leftIcon ? 'pl-9' : 'pl-2.5',
rightIcon ? 'pr-9' : 'pr-2.5',
inputVariants({ className, isError, size, isRounded, variant })
)}
/>
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/components/v2/Modal/Modal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ export const ModalContent = forwardRef<HTMLDivElement, ModalContentProps>(
<IconButton
variant="plain"
ariaLabel="close"
className="absolute top-2.5 right-2.5 rounded text-white hover:bg-gray-600"
className="absolute top-3 right-3 rounded text-white hover:bg-gray-600"
>
<FontAwesomeIcon icon={faTimes} size="sm" className="cursor-pointer" />
<FontAwesomeIcon icon={faTimes} size="lg" className="cursor-pointer" />
</IconButton>
</DialogPrimitive.Close>
</Card>
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/v2/Table/Table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export type TrProps = {
} & HTMLAttributes<HTMLTableRowElement>;

export const Tr = ({ children, className, ...props }: TrProps): JSX.Element => (
<tr className={twMerge('border border-solid border-mineshaft-700', className)} {...props}>
<tr className={twMerge('border border-solid border-mineshaft-700 hover:bg-bunker-700', className)} {...props}>
{children}
</tr>
);
Expand All @@ -71,7 +71,7 @@ export type ThProps = {
};

export const Th = ({ children, className }: ThProps): JSX.Element => (
<th className={twMerge('px-6 py-3 font-medium', className)}>{children}</th>
<th className={twMerge('px-5 pt-4 pb-3.5 font-medium font-semibold bg-bunker-500', className)}>{children}</th>
);

// table body
Expand All @@ -91,7 +91,7 @@ export type TdProps = {
} & TdHTMLAttributes<HTMLTableCellElement>;

export const Td = ({ children, className, ...props }: TdProps): JSX.Element => (
<td className={twMerge('px-6 py-3 text-left', className)} {...props}>
<td className={twMerge('px-5 py-2 text-left', className)} {...props}>
{children}
</td>
);
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export const ProjectSettingsPage = () => {
const host = window.location.origin;
const isEnvServiceAllowed =
subscriptionPlan !== plans.starter || host !== 'https://app.infisical.com';


const onRenameWorkspace = async (name: string) => {
try {
Expand Down Expand Up @@ -188,14 +189,14 @@ export const ProjectSettingsPage = () => {
});
console.log(res);
createNotification({
text: 'Successfully created API token',
text: 'Successfully created a service token',
type: 'success'
});
return res.serviceToken;
} catch (error) {
console.error(error);
createNotification({
text: 'Failed to create API token',
text: 'Failed to create a service token',
type: 'error'
});
}
Expand Down Expand Up @@ -251,13 +252,13 @@ export const ProjectSettingsPage = () => {
workspaceName={currentWorkspace?.name || ''}
onCreateToken={onCreateServiceToken}
/>
<div className="mb-6 mt-4 flex w-full flex-col items-start rounded-md border-l border-red bg-white/5 px-6 pl-6 pb-4 pt-2">
<div className="mb-6 mt-4 flex w-full flex-col items-start rounded-md border-l border-red bg-white/5 px-6 pl-6 pb-4 pt-4">
<p className="text-xl font-bold text-red">{t('settings-project:danger-zone')}</p>
<p className="text-md mt-2 text-gray-400">{t('settings-project:danger-zone-note')}</p>
<div className="mr-auto mt-4 max-h-28 w-full max-w-md">
<FormControl
label={
<div className="mb-2 text-sm font-normal text-gray-400">
<div className="mb-0.5 text-sm font-normal text-gray-400">
Type <span className="font-bold">{currentWorkspace?.name}</span> to delete the
workspace
</div>
Expand All @@ -278,7 +279,7 @@ export const ProjectSettingsPage = () => {
>
{t('settings-project:delete-project')}
</Button>
<p className="mt-0.5 ml-1 text-xs text-gray-500">
<p className="mt-3 ml-0.5 text-xs text-gray-500">
{t('settings-project:delete-project-note')}
</p>
</div>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Controller, useForm } from 'react-hook-form';
import { faPencil, faTrashCan } from '@fortawesome/free-solid-svg-icons';
import { faPencil, faPlus, faTrashCan } from '@fortawesome/free-solid-svg-icons';
import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
import { yupResolver } from '@hookform/resolvers/yup';
import * as yup from 'yup';
Expand Down Expand Up @@ -100,6 +100,7 @@ export const EnvironmentSection = ({
}
}}
colorSchema="primary"
leftIcon={<FontAwesomeIcon icon={faPlus} />}
>
Add New Env
</Button>
Expand All @@ -122,7 +123,7 @@ export const EnvironmentSection = ({
<Td>{slug}</Td>
<Td className="flex items-center justify-end">
<IconButton
className="mr-4"
className="mr-3"
onClick={() => {
if (isEnvServiceAllowed) {
handlePopUpOpen('createUpdateEnv', { name, slug });
Expand Down Expand Up @@ -154,8 +155,8 @@ export const EnvironmentSection = ({
))
) : (
<Tr>
<Td colSpan={4} className="pt-7 pb-4 text-center text-bunker-400">
No environmants found
<Td colSpan={4} className="pt-7 pb-5 text-center text-bunker-400">
No environments found
</Td>
</Tr>
)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ export const ProjectNameChangeSection = ({

return (
<form onSubmit={handleSubmit(onFormSubmit)}>
<div className="mb-6 flex w-full flex-col items-start rounded-md bg-white/5 px-6 pb-4 pt-2">
<div className="mb-6 flex w-full flex-col items-start rounded-md bg-white/5 px-6 pb-6 pt-3">
<p className="mb-4 mt-2 text-xl font-semibold">{t('common:display-name')}</p>
<div className="mb-4 w-full max-w-lg">
<div className="mb-2 w-full max-w-lg">
<Controller
defaultValue=""
render={({ field, fieldState: { error } }) => (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,6 @@ export const ServiceTokenSection = ({
<Td>{new Date(row.expiresAt).toUTCString()}</Td>
<Td className="flex items-center justify-end">
<IconButton
className="mr-4"
onClick={() =>
handlePopUpOpen('deleteAPITokenConfirmation', {
name: row.name,
Expand All @@ -294,8 +293,8 @@ export const ServiceTokenSection = ({
))
) : (
<Tr>
<Td colSpan={4} className="pt-7 pb-4 text-center text-bunker-400">
No environmants found
<Td colSpan={4} className="py-6 text-center text-bunker-400">
No service tokens found
</Td>
</Tr>
)}
Expand Down

0 comments on commit fca003d

Please sign in to comment.