refactor: Change type to ensure notifs within state are Required<>

Infisical · Dec 7, 2022 · 9098bdc · 9098bdc
1 parent 251426b
commit 9098bdc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/frontend/components/context/Notifications/Notification.tsx b/frontend/components/context/Notifications/Notification.tsx
@@ -6,7 +6,7 @@ import classnames from "classnames";
 import { Notification as NotificationType } from "./NotificationProvider";
 
 interface NotificationProps {
-  notification: NotificationType;
+  notification: Required<NotificationType>;
   clearNotification: (text: string) => void;
 }
 

diff --git a/frontend/components/context/Notifications/NotificationProvider.tsx b/frontend/components/context/Notifications/NotificationProvider.tsx
@@ -25,7 +25,9 @@ interface NotificationProviderProps {
 }
 
 const NotificationProvider = ({ children }: NotificationProviderProps) => {
-  const [notifications, setNotifications] = useState<Notification[]>([]);
+  const [notifications, setNotifications] = useState<Required<Notification>[]>(
+    []
+  );
 
   const clearNotification = (text: string) => {
     return setNotifications((state) =>
@@ -44,7 +46,7 @@ const NotificationProvider = ({ children }: NotificationProviderProps) => {
       return;
     }
 
-    const newNotification: Notification = { text, type, timeoutMs };
+    const newNotification: Required<Notification> = { text, type, timeoutMs };
 
     return setNotifications((state) => [...state, newNotification]);
   };

diff --git a/frontend/components/context/Notifications/Notifications.tsx b/frontend/components/context/Notifications/Notifications.tsx
@@ -2,7 +2,7 @@ import Notification from "./Notification";
 import { Notification as NotificationType } from "./NotificationProvider";
 
 interface NoticationsProps {
-  notifications: NotificationType[];
+  notifications: Required<NotificationType>[];
   clearNotification: (text: string) => void;
 }