Provide reference to BrightnessController in DisplayApp #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with the changes. Could you fix the conflict so we can merge? |
For the simulator I need a way to get to the brightnessController object and handle the set brightness-levels accoringly. This is done by the constructor expecting a brightnessController object instead of initializing one itself
NeroBurner
force-pushed
the
displayapp_brightnesscontroller_reference
branch
from
10f47a2
to
0b1ce97
Compare
|
rebased :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the simulator I need a way to get to the brightnessController object
and handle the set brightness-levels accordingly.
This is done by the constructor expecting a brightnessController object
instead of initializing one itself.
If this change is too intrusive adding a function like
getBrightnessLevel()to just the mainDisplayApp.hforwarding the brightness level of the internally storedBrightnessControllerwould be another way forward for me.Or return a reference with
getBrightnessController()