Repository navigation
knowledge: capture CI debugging and performance validation lessons - #173
Conversation
Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
Signed-off-by: tzhouam <tzhouam@connect.ust.hk>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c59dbbf526
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| |---|---| | ||
| | 理解配置从 deploy、CLI、默认 factory 到 structured/legacy config 的稳定边界 | [配置构造架构](architecture.md) | | ||
| | 根据 PR 描述直达 strict schema、pipeline sampling constraints、deploy/topology、composable strategy、global engine args 的 owner 校验、CLI-only 负向 alias 或显存配置的规则组与第一批源码 | [配置开发门禁与代码地图](rules.md) | | ||
| | 根据 PR 描述直达 strict schema、pipeline sampling constraints、deploy/topology、composable strategy、global engine args 的 owner 校验、CLI-only 负向 alias 或显存配置的规则组与第一批源码、环境变量 inventory | [配置开发门禁与代码地图](rules.md) | |
There was a problem hiding this comment.
When a task adds or reviews an environment variable, this new route competes with the existing route on line 50 to environment-variable-contract.md, while VOMNI-CFG-3a repeats that page's executable review gates at lines 35–40. This creates two owner-local sources of truth that can drift—the existing page additionally requires prefix classification and live scanning—contrary to the repository's union-first requirement; consolidate the executable gate in rules.md and make the guide/index route link to that single rule.
AGENTS.md reference: AGENTS.md:L7-L11
Useful? React with 👍 / 👎.
1 participant
CI fixes can pass on a newer local runtime while still failing in the target lane, and small realtime timing changes can be indistinguishable from baseline drift. Add reusable rules from vllm-project/vllm-omni#7648 to the CI, configuration, diffusion, and benchmark owners, with index and routing updates.
The rules cover Buildkite job evidence and runtime boundaries, environment-variable inventory consistency, mutable custom-op schema defaults and fullgraph validation, and repeated-control performance checks. Preserve existing upstream rules and use distinct rule IDs. No raw logs or machine-specific data are included.
Validation: