optimize-checks #36
Open
optimize-checks #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I find this harder to ready, certainly hiding assignment away in a ternary raises an eyebrow. It also won't work if the user passes an undefined value for the final argument, though it's debatable if that should be supported. You have provided no description, does this solve a problem you've been having? |
|
Hi @achingbrain - it doesn't solve any problem, however I just had a thought to reduce line of code. Further about hiding the assignment in ternary - it's also possible there, but since all test cases were passing without it, I thought to drop that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.