Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal Plugin Code Review PR #3

Closed
wants to merge 92 commits into from
Closed

Internal Plugin Code Review PR #3

wants to merge 92 commits into from

Conversation

dbluhm
Copy link
Member

@dbluhm dbluhm commented Nov 22, 2023

No description provided.

burdettadam and others added 30 commits November 22, 2023 10:19
@burdettadam @dbluhm
feat: first of oid4vci plugin files
b87d1a3 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam @dbluhm
BUG: non working docker
8621c21 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam @dbluhm
BUG: non working docker
e86887c 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam @dbluhm
feat: working docker img
24ac4f3 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam @dbluhm
feat: loading plugin with status points
362c622 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam @dbluhm
feat: empty handlers
40629aa 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam @dbluhm
feat: some openapi schemas
6859e74 
Signed-off-by: Adam Burdett <[email protected]>
@cjhowland @dbluhm
feat: add logic to get_cred_offer endpoint
b6b88fd 
Signed-off-by: Char Howland <[email protected]>
@cjhowland @dbluhm
feat: create CredentialOfferRecord
a4be6ac 
Signed-off-by: Char Howland <[email protected]>
@burdettadam @dbluhm
feat: no head allowed on get's
515367b 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam @dbluhm
feat: check jwt token
0b90f07 
Signed-off-by: Adam Burdett <[email protected]>
@cjhowland @dbluhm
feat: oid_cred_issuer logic (WIP)
7235d78 
Signed-off-by: Char Howland <[email protected]>
@burdettadam @dbluhm
feat: mostly copied routes.py
b4d28ee 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam @dbluhm
feat: demo directory
590fbe8 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam @dbluhm
feat: demo frontend with docker compose
d6f3355 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam @dbluhm
feat: demo docker compose with less bugs
62666ff 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam @dbluhm
feat: cred ex record management
93d5989 
Signed-off-by: Adam Burdett <[email protected]>
@dbluhm
chore: add pre-commit
ec4fcbd 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: remove unused record
72cb59d 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: models into model package
100a98d 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: minor tweaks to issuer meta endpoint
4d3050a 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: move public routes to new module
951d615 
Signed-off-by: Daniel Bluhm <[email protected]>
@burdettadam @dbluhm
feat: more code
f3d20b2 
Signed-off-by: Adam Burdett <[email protected]>
@dbluhm
refactor: minor tweaks, draft 13 compliance
2928c4f 
Signed-off-by: Daniel Bluhm <[email protected]>
@burdettadam @dbluhm
feat: docker_compose with ngrok
b01dc97 
Signed-off-by: Adam Burdett <[email protected]>
@dbluhm
fix: exchange record schema issues
2ded9f4 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: shorten the name of exchange record
e02398f 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: rename model module
51c37b5 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: rename records a bit
22e933a 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: rename model module
3bcccdd 
Signed-off-by: Daniel Bluhm <[email protected]>
dbluhm and others added 27 commits November 22, 2023 22:05
@dbluhm
feat: add config object
d7d51c7 
For reliably retrieving configuration values from plugin config or
environment

Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: rearrange plugin structure slightly
c6a6ac7 
Since this is not a DIDComm protocol plugin, it doesn't make sense to
follow the same conventions

Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: refine configuration object
b21aaa7 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: further refine config object; errors
b299851 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: minimize oid4vci server responsibilities
4940448 
I think some of the previous endpoints are undesirable for public
endpoints.

Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
chore: small clean up in public routes
d6f6213 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: minor rearrangement of route models
c3e8df4 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: refine record listing
a37061e 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
refactor: refine admin endpoints further
a8068dc 
PIN should be set on record creation

Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
feat: implement supported credential deletion
7e3c4a0 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
feat: implement pin support and token expiry
8049510 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
feat: add did:jwk resolver
c16996c 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
feat: implement proof of possession verification
9d4247d 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
fix: save record state on offer created
0f39086 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
fix: failing tests, missing config
47bbc5f 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
fix: types checking, issues in int tests
f4b7b9c 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
fix: signature is b64url encoded
17891f5 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
test: es256k pop
cc238b0 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
fix: small fixes
9104072 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm
chore: bump askar, acapy versions
95e1fd0 
Signed-off-by: Daniel Bluhm <[email protected]>
@burdettadam
fix: add registration admin page
be2f66a 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam
fix: remove credential page, fix get by id
f086449 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam
fix: cleaner demo code with async
5ce0874 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam
fix: vars names
76a89bd 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam
feat: better error reporting
d59588f 
Signed-off-by: Adam Burdett <[email protected]>
@burdettadam
feat: webpage name change
b8ccd7d 
Signed-off-by: Adam Burdett <[email protected]>
@dbluhm
feat: update readme
e5b03f4 
Signed-off-by: Daniel Bluhm <[email protected]>
@dbluhm dbluhm closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burdettadam burdettadam burdettadam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbluhm @burdettadam @cjhowland