Slider number range extension #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r most of the code to keep working as expected. Thus here check the upper bound only if the lower bound was not at fault.
…e current type the compiler might optimize this the same way - for C++ classes with overridden operators however this distinction might prove relevant. So, allthough it is practically irrelevant here, just keep it as a best-practice for writing code.
…. As to avoid descretization errors which would have resulted from dividing first and scaling to the new range afterwards and because floats would not have yielded any better result here, just cast to the next bigger format int32_t, which can for sure contain all results of a multiplication of two int16_t.
|
Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use a slider with values from 0 to 255 and a width of 256. This however lead to the following strange behaviour:
- The slider marker could wrapped around at approx. the center of the slider and appeared to the left of the slider [outwards].
- I could also move the slider marker to the right of the slider [outwards], while the slider value returned wrapped around to 0 [stayed positive].
These changes only affect the visuals.