Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gslc_ElemSetVisible() does not work #156

Closed
LowPowerLab opened this issue Jul 19, 2019 · 3 comments
Closed

gslc_ElemSetVisible() does not work #156

LowPowerLab opened this issue Jul 19, 2019 · 3 comments
Assignees
Labels
bug fixed Addressed bug or implementation change
Milestone

Comments

@LowPowerLab
Copy link

It appears that calling gslc_ElemSetVisible(&m_gui, _A_BUTTON_, false); on a button, only disables the button, but does not hide it when the display is refreshed.

I found this comment in XKeyPad.c but I'm not sure if this is specific to that component or it really refers to gslc_ElemSetVisible not yet working at all:
// FIXME: Need to fix dynamic visibility change
// gslc_ElemSetVisible(pGui, pElemRefTmp, bVisible);

Platform:
MoteinoM0 (CortexM0+ SAMD21G18A 48Mhz)
ILI9341 2.4" + Touchscreen
#define GUISLICE_VER "0.12.1"
#include "../configs/ard-adagfx-ili9341-xpt2046.h"
Arduino 1.8.7

@ImpulseAdventure ImpulseAdventure self-assigned this Jul 20, 2019
@ImpulseAdventure ImpulseAdventure added bug waiting confirm Believed to be fixed / OK. Waiting on confirmation. labels Jul 20, 2019
@ImpulseAdventure
Copy link
Owner

Hi @LowPowerLab -- you're right! Thanks for reporting this and providing the helpful supporting details.

I have now checked in a fix to support hiding of elements via ElemSetVisible().
Please try the latest GitHub master and let me know if the functionality works correctly for you now.

@ImpulseAdventure ImpulseAdventure added this to the 0.13.0 milestone Jul 20, 2019
@LowPowerLab
Copy link
Author

That works, thanks for the quick resolution!

@ImpulseAdventure ImpulseAdventure added fixed Addressed bug or implementation change and removed waiting confirm Believed to be fixed / OK. Waiting on confirmation. labels Jul 21, 2019
@ImpulseAdventure
Copy link
Owner

Great - thank you for the followup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed Addressed bug or implementation change
Projects
None yet
Development

No branches or pull requests

2 participants