Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mayavi github dependency restored for hotfix #311

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Mayavi github dependency restored for hotfix #311

wants to merge 23 commits into from

Conversation

kccwing
Copy link
Collaborator

@kccwing kccwing commented Dec 12, 2024

kccwing and others added 23 commits December 12, 2024 08:11
@kccwing
Mayavi github dependency restored for hotfix
72368b0 
enthought/mayavi#1289
@ben-l-p
Changed Mayavi source branch
95462e6
@ben-l-p
Update SHARPy test to use pip install to compile libraries
e9734b5
@ben-l-p
Update workflow with explicit installation of OpenBLAS
99cd0f1
@ben-l-p
Revert "Update workflow with explicit installation of OpenBLAS"
3b29493 
This reverts commit 99cd0f1.
@ben-l-p
Reapply "Update workflow with explicit installation of OpenBLAS"
b29c18d 
This reverts commit 3b29493.
@ben-l-p
Revert "Reapply "Update workflow with explicit installation of OpenBL…
8b8e8e9 
…AS""

This reverts commit b29c18d.
@wong-hl
Update actions versions
65619be
@wong-hl
Temporarily remove specifying master version of mayavi
9ea90a1
@wong-hl
Add blas and lapack as dependencies to install
87cfbcd
@wong-hl
Added missing comma
df549c6
@wong-hl
Remove commented out mayavi dependency
3f96d7a
@wong-hl
Move gfortran and dependency installation into separate steps
31f9664
@wong-hl
Added fetch tags to checkout, this shoudl mean the git fetch command …
5862722 
…isn't needed later
@wong-hl
Move running coverage into a separate step
f0557d2
@wong-hl
Put the mayavi master dependency back as it seems like it's a fix for…
6278109 
… the failing unit tests
@wong-hl
Fix typo in checkout action
d4ee832
@wong-hl
Seems like it's not just me that can't find the zipball, try main as …
ec234a3 
…that's the default branch name
@wong-hl
Made submodule checkout recursive (like in docs)
7db03e5
@wong-hl
Revert back to just mayavi as the tar can't be found
c163397
@wong-hl
Remove the git commands which should be unnecessary now
f345e0f
@wong-hl
Updated name of the step to reflect reduced scope
21c87be
@wong-hl
Merge branch 'main' into dev_hotfixmayavi
6c406ea
@wong-hl
Copy link
Contributor

wong-hl commented Feb 18, 2025

I've fixed the blas bug and cleaned up the workflow file. It is currently failing on the unit tests highlighted in issue #313. I tried putting in the fix that @ben-l-p mentioned in the issue. However, the tarball can't be found making it fail at the build/installation stage. This is most likely due to them updating their default branch from master to main (see mayavi PR). I tried updating the URL to have main instead of master and that failed too :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kccwing @wong-hl @ben-l-p