-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with php 8.4 and newer ImageMagick library versions #699
base: master
Are you sure you want to change the base?
Conversation
* Fix skewness and kurtosis test after 7.1.1-24 calculation method change * declare MAGICK_LIB_VERSION_GTE macro to help preprocessor code filtering * replace `php_strtolower` wtih `zend_str_tolower` method calls due to deprecation in 8.4
@Danack Check this, please :) |
(see also #690, which this has overlap with) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch works fine for PHP 8.4 installed by homebrew on macOS (ARM).
I have some problems when installing the patch with php-ext-installer, her's the result:
|
@Fabccc This PR originates from the master branch, which clearly hasn't been updated in a long time. I've prepared a fix based on the develop branch: develop-php8.4-patch. The PR is available here: #704. Try that patch - it should work. |
@michalananapps Hi! |
php_strtolower
wtihzend_str_tolower
method calls due to deprecation in 8.4