Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullable in Imagick.stub.php #674

Closed
wants to merge 3 commits into from
Closed

Fix nullable in Imagick.stub.php #674

wants to merge 3 commits into from

Conversation

mvorisek
Copy link

CI build error:

Imagick::newImage(): Parameter format has null default, but is not nullable
make: *** [Makefile:195: /tmp/pear/temp/imagick/Imagick_arginfo.h] Error 1

@mvorisek
Copy link
Author

mvorisek commented Jun 18, 2024

@Danack can you to merge this PR in order to support PHP 8.4/php-src master?

@Danack
Copy link
Collaborator

Danack commented Jul 2, 2024

Thanks. I also added a test and fixed the parameter parsing which needed tweaking.

I also fixed another one that showed up in ImagickKernel::fromMatrix.

I'm going to leave the numbers in the YML for the moment for reasons.

btw, if you have time to look at #679 it would be appreciated.

@Danack Danack closed this Jul 2, 2024
@mvorisek mvorisek deleted the fix-nullable-stub branch July 6, 2024 07:36
@mvorisek
Copy link
Author

mvorisek commented Jul 6, 2024

I'm going to leave the numbers in the YML for the moment for reasons.

May I know your concerns?

The numbers in YML must be escaped in quotes otherwise version like 8.0 is parsed as floating point number instead of string which converts such value (when casted back to a string) into 8 string which is unwanted.

Example:

image

@annuh
Copy link

annuh commented Nov 7, 2024

Thanks for looking into this!

Was there a reason to not merge this? I'm getting this error now as well:

docker run -it php:8.4-rc /bin/bash
# in the container:
curl -sSLf \
        -o /usr/local/bin/install-php-extensions \
        https://github.com/mlocati/docker-php-extension-installer/releases/latest/download/install-php-extensions && \
    chmod +x /usr/local/bin/install-php-extensions && \
    install-php-extensions imagick/imagick@master

Results in the following error:

In /tmp/pear/temp/imagick/Imagick.stub.php:
Imagick::newImage(): Parameter format has null default, but is not nullable
make: *** [Makefile:191: /tmp/pear/temp/imagick/Imagick_arginfo.h] Error 1
ERROR: `make -j10 INSTALL_ROOT="/tmp/pear/temp/pear-build-defaultuser2fmsck2230q5bGTayAL/install-imagick-3.7.0" install' failed

@mvorisek
Copy link
Author

Feel free to use my https://github.com/mvorisek/image-php Docker images. There are built every 2 weeks with a lot of extensions - https://github.com/mvorisek/image-php/blob/master/test.php incl. this one.

annuh added a commit to annuh/imagick that referenced this pull request Nov 15, 2024
annuh added a commit to annuh/imagick that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants