-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nullable in Imagick.stub.php #674
Conversation
@Danack can you to merge this PR in order to support PHP 8.4/php-src master? |
Thanks. I also added a test and fixed the parameter parsing which needed tweaking. I also fixed another one that showed up in ImagickKernel::fromMatrix. I'm going to leave the numbers in the YML for the moment for reasons. btw, if you have time to look at #679 it would be appreciated. |
May I know your concerns? The numbers in YML must be escaped in quotes otherwise version like Example: |
Thanks for looking into this! Was there a reason to not merge this? I'm getting this error now as well:
Results in the following error:
|
Feel free to use my https://github.com/mvorisek/image-php Docker images. There are built every 2 weeks with a lot of extensions - https://github.com/mvorisek/image-php/blob/master/test.php incl. this one. |
…ot nullable Credits: Imagick#674
…ot nullable Credits: Imagick#674
CI build error: